Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to choose background interaction mode (.dismiss / .forward or .none) #115

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add ability to choose background interaction mode (.dismiss / .forward or .none) #115

wants to merge 4 commits into from
+75 −6

Conversation

ilia3546
Copy link

@ilia3546 ilia3546 commented Aug 19, 2020 •
edited
Loading

Summary

Related issue - #100

Now you can choose one of background interaction modes:

  • .dismiss - Taps dismiss the modal immediately
  • .forward - Touches are forwarded to the lower window (In most cases it would be the application main window that will handle it
  • .none - Absorbs touches. The modal does nothing (Swallows the touch)

Example:

class MyPanModal: UIViewController, PanModalPresentable {

    ...

    var backgroundInteraction: PanModalBackgroundInteraction {
        return .forward
    }

}

I think now option allowsTapToDismiss can be marked as deprecated.

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.

  • I've read and agree to the Code of Conduct.

  • I've written tests to cover the new code and functionality included in this PR.

@CLAassistant
Copy link

CLAassistant commented Aug 19, 2020 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ ilia3546
❌ Ilya Kharlamov

Ilya Kharlamov seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ilia3546 ilia3546 marked this pull request as ready for review August 19, 2020 13:23
@devxoul
Copy link

devxoul commented Nov 2, 2020

I really look forward to have this functionality!

@a777med
Copy link

a777med commented Dec 7, 2020

Please, could someone with write access review this PR? I have stopped using this library because of this issue. @jordanpichler @ste57 @TosinAF @Marcocanc

@jordanpichler
Copy link
Contributor

Sadly I don't have write access to approve this PR.

@a777med you can always point your dependency manager (Cocoapods or Swift Package Manager) to @ilia3546 branch to include this PR. No need to wait for Slack to create a release with this PR 😉

@lhr000lhrmega
Copy link

Hi guys,
it's been a while not have any update on this PR.

Do we have a plan to merge it?

@ivopintodasilva
Copy link

Works really well! 💯 Hope it gets merged soon

ivopintodasilva added a commit to amieso/PanModal that referenced this pull request Mar 11, 2021
@ivopintodasilva
Background interaction from slackhq#115
5083989
@alvincrisuy
Copy link

Still not yet being merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stinger stinger stinger approved these changes

@javikr javikr javikr approved these changes

@ste57 ste57 ste57 approved these changes

@manucodin manucodin manucodin approved these changes

@a777med a777med a777med approved these changes

@kuuhaku0 kuuhaku0 kuuhaku0 approved these changes

@zzisun zzisun zzisun approved these changes

@ziv-mishloha ziv-mishloha ziv-mishloha approved these changes

@RelativeJoe RelativeJoe RelativeJoe approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.